Skip to content

adjust ci matrix #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikemhenry merged 1 commit into from
Jul 28, 2025
Merged

adjust ci matrix #394

mikemhenry merged 1 commit into from
Jul 28, 2025

Conversation

@mikemhenry
Copy link
Collaborator

@mikemhenry mikemhenry commented Jul 25, 2025

drop python 3.10, add 3.13 and drop openmm 8.1.2 and test 8.3.1

@mikemhenry mikemhenry mentioned this pull request Jul 25, 2025
Merged
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.41%. Comparing base (b299813) to head (726d7b8).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files           5        5           
  Lines         822      822           
=======================================
  Hits          587      587           
  Misses        235      235

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@epretti
Copy link
Member

epretti commented Jul 25, 2025

We can probably also update test_charmm.yaml to use Python 3.13 and OpenMM 8.3.1. That's been on 8.2.0dev1 for a while since there was a bug in 8.2.0 preventing the CHARMM validation from working, but it should be fixed now in the 8.3 releases.

@mattwthompson
Copy link
Collaborator

mattwthompson commented Jul 26, 2025

Don't know why these are showing up as required checks, but they're not gonna land if they're removed

image

mattwthompson
mattwthompson approved these changes Jul 26, 2025
View reviewed changes
Copy link
Collaborator

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with force-merging given the quirk of changing requirements

@mikemhenry mikemhenry merged commit 5d0c607 into main Jul 28, 2025
14 checks passed
@mikemhenry mikemhenry deleted the feat/adjust-ci-matrix branch July 28, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattwthompson mattwthompson mattwthompson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikemhenry @codecov-commenter @epretti @mattwthompson