Skip to content

Conversation

@mattwthompson
Copy link
Collaborator

This PR fixes a few of the more obsolete details of the README:

  • The default SMIRNOFF force field is/has been some version of Sage for some time but is sometimes referred to inaccurately
  • Parsley 1.2.0 is recommended in some places, this is now Sage 2.1.0
  • smirnoff99Frosst is given a lot of attention in this user-facing document, but at this point it's mostly a historical artifact that's interesting for force field developers. It's not something we would recommend in new projects as a starting point

I did not change any behavior in the source code here, though I would like the default SMIRNOFF force field to be bumped to 2.2.0 or 2.2.1 in another change.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.41%. Comparing base (624b690) to head (577402d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #389   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files           5        5           
  Lines         822      822           
=======================================
  Hits          587      587           
  Misses        235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattwthompson mattwthompson marked this pull request as ready for review July 14, 2025 21:10
@epretti epretti self-requested a review July 15, 2025 20:31
@mattwthompson mattwthompson merged commit b299813 into main Jul 15, 2025
14 checks passed
@mattwthompson mattwthompson deleted the parsley-is-old-now branch July 15, 2025 20:39
@mattwthompson mattwthompson mentioned this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants