Skip to content

Conversation

@mikemhenry
Copy link
Collaborator

No description provided.

@mikemhenry mikemhenry requested a review from mattwthompson July 24, 2024 22:32
@mikemhenry mikemhenry enabled auto-merge (squash) July 24, 2024 22:32
@mikemhenry mikemhenry changed the title run latest version of openmm run latest version of openmm in CI Jul 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.57%. Comparing base (051cbcb) to head (94657ed).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   69.57%   69.57%           
=======================================
  Files           5        5           
  Lines         825      825           
=======================================
  Hits          574      574           
  Misses        251      251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- pytest-xdist
- pytest-randomly
- openmm <8.1.1
- openmm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle you'd want to run against 8.1.2 and something older, but I don't care too much about that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good idea to catch regressions, I'll make an issue and get to it someday

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattwthompson decided it was easy enough to add to this PR

@mikemhenry mikemhenry disabled auto-merge July 26, 2024 18:34
@mikemhenry
Copy link
Collaborator Author

Looks good! I just need to clean up the branch rules so it's not waiting for tests that never come.

@mikemhenry mikemhenry merged commit 72431bb into main Jul 29, 2024
@mikemhenry mikemhenry deleted the fix/update_ci branch July 29, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants