Fix system and template generator for Espaloma 0.3.* #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… EspalomaTemplateGenerator
…nd template_generator.py
1 task
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 69.35% 67.95% -1.40%
==========================================
Files 5 5
Lines 855 877 +22
==========================================
+ Hits 593 596 +3
- Misses 262 281 +19
☔ View full report in Codecov by Sentry. |
jchodera
reviewed
Sep 23, 2023
mikemhenry
reviewed
Sep 25, 2023
Member
|
@mikemhenry @ijpulidos : I've finished cleaning up the docs and running local tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new PR with these changes such that we can use the CI secrets from our repo. Supersedes #271
These changes add
template_generator_kwargsto the system generators.Resolves #245 . Resolves #263 . Resolves #282
TODO