Do not symlink data files in setup.py
#229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the deprecation of
python setup.py, confusion (#124) and strange, difficult-to-diagnose behavior in CI (#225) I wanted to experiment with simplifying the distribution of data files by packaging them directly instead of creating symbolic links to them. Symlinks are generally not portable - may or may not help with the Windows issues. As far as I can tell, this requires no changes to the discovery machinery aroundopenmm.forcefielddir.This gets
python -m pip install .working on my machine with both direct and editable installs.