Skip to content

Conversation

@dotsdl
Copy link

@dotsdl dotsdl commented Jun 24, 2020

Adds a small warning for developers to the README; I got bit by this today.

@dotsdl dotsdl mentioned this pull request Jun 24, 2020
2 tasks
@jchodera
Copy link
Member

Is there a way to remedy this issue by modifying setup.py?

@dotsdl
Copy link
Author

dotsdl commented Jun 24, 2020

Let me see what I can do. I'll add changes to this PR if I can make this work smoothly with minimal changes.

@dotsdl
Copy link
Author

dotsdl commented Jun 24, 2020

I don't have a good fix for this beyond:

  1. Migrating the ff files into the package structure tree, where they will end up on a normal install.
  2. Removing the os.unlinks in the finally block in setup.py; basically, not cleaning up.

I've looked around to see if using pip install -e . introduces some hooks we could grab onto for making the os.unlinks conditional. I would have to do a deeper dive to find such a thing than I've done so far.

I don't mind not being able to pip install -e . personally; it's usually my first reflex, but this isn't the only package I know of that has idiosyncrasies around that. The note I've added to the README satisfies me.

@mattwthompson
Copy link
Collaborator

I've ~fixed this in #230/#227 by just including the files in the module structure directly. This might add some weight in packaging, but there are ways around that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants