Retry on database error to reduce number of test failures #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
requested changes
Oct 29, 2020
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
I think it makes sense to treat a connection error the same as a server is busy is error. I have a minor suggestion for making sure the code reflects that. Other than that I agree with the PR.
PGijsbers
approved these changes
Oct 30, 2020
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
(let's see some green from CI first, but otherwise 👍 )
Contributor
|
@all-contributors please add @mfeurer for code |
Contributor
|
I've put up a pull request to add @mfeurer! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/fix? Explain your changes.
This PR adds a retry mechanism to api calls in case it detects a database error.
How should this PR be tested?
New unit test. Also, an overloaded test server.