Updated the way 'image features' are stored #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added unit test, fixed typo
Collaborator
|
To be clear; this PR supersedes #892 (I imagine because it's easier than dealing with merge conflicts)? |
Member
Author
@PGijsbers yes exactly, the last commit was nearly 1 year ago. |
mfeurer
approved these changes
Oct 29, 2020
Contributor
|
@all-contributors please add @ArlindKadra for code |
Contributor
|
I've put up a pull request to add @ArlindKadra! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #891. Credit goes to @amueller since he did all the important work in #892
What does this PR implement/fix? Explain your changes.
Changes the way that numerical features are stored. Numerical features that range from 0 to 255 are now stored as uint8, which reduces the storage space required as well as storing and loading times.
How should this PR be tested?
With the added unit test and with the updated old ones.