Skip to content

add validation for ignore_attributes and default_target_attribute at … #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PGijsbers merged 7 commits into from
Oct 29, 2020
Merged

add validation for ignore_attributes and default_target_attribute at … #978

PGijsbers merged 7 commits into from
Oct 29, 2020

Conversation

@a-moadel
Copy link
Contributor

@a-moadel a-moadel commented Oct 28, 2020

…craete_dataset

Reference Issue

#964

What does this PR implement/fix? Explain your changes.
  1. First for ignore_attributes and default_target_attribute expand to list if they are comma sperated strings.
  2. check for both attributes that all values are ie columns.

How should this PR be tested?

on call of create_dataset , we can try values for ignore_attributes and default_target_attribute that are part of the columns and some values that are not.

Any other comments?

PGijsbers
PGijsbers reviewed Oct 28, 2020
View reviewed changes
PGijsbers
PGijsbers reviewed Oct 28, 2020
View reviewed changes
PGijsbers
PGijsbers reviewed Oct 28, 2020
View reviewed changes
PGijsbers
PGijsbers reviewed Oct 28, 2020
View reviewed changes
PGijsbers
PGijsbers reviewed Oct 28, 2020
View reviewed changes
PGijsbers
PGijsbers reviewed Oct 28, 2020
View reviewed changes
PGijsbers
PGijsbers reviewed Oct 28, 2020
View reviewed changes
tests/test_datasets/test_dataset_functions.py
language=language,
licence=licence,
default_target_attribute=default_target_attribute,
default_target_attribute="play",
Copy link
Collaborator

@PGijsbers PGijsbers Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change these tests?

Copy link
Contributor Author

@a-moadel a-moadel Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one will fail because of the new logic , as "play" is not in the dataset columns.

Copy link
Collaborator

@PGijsbers PGijsbers Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But previously it was also set to "play"? And it says column_names = ["rnd_str", "outlook", "temperature", "humidity", "windy", "play"] just a few lines up. I am a bit confused about this. Maybe sitting together for this works better.

PGijsbers
PGijsbers requested changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some questions and feedback that I'd like to see addressed 👍

PGijsbers
PGijsbers reviewed Oct 28, 2020
View reviewed changes
PGijsbers
PGijsbers reviewed Oct 28, 2020
View reviewed changes
@PGijsbers
Copy link
Collaborator

PGijsbers commented Oct 29, 2020

I forgot about this earlier, could you also add a test which tests the new functionality that allows a number of attributes to be specified by a comma-separated string? (e.g. ignore_attribute="windy,outlook"

@PGijsbers PGijsbers merged commit 3132dac into openml:develop Oct 29, 2020
@PGijsbers
Copy link
Collaborator

PGijsbers commented Oct 29, 2020

Thanks 🎉

@PGijsbers PGijsbers mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PGijsbers PGijsbers PGijsbers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a-moadel @PGijsbers @madel0093