Skip to content

Conversation

@chouhanaryan
Copy link
Contributor

Reference Issue

Fixes #371 (partially?)

What does this PR implement/fix? Explain your changes.

Changes default value of parameter size of list_evaluations to 10000.

How should this PR be tested?

  • All tests that use this function need to be updated to ensure it works properly.

Any other comments?

None.

@chouhanaryan
Copy link
Contributor Author

@PGijsbers Sorry, I'm not entirely sure what to add to doc/progress.rst.

Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry I wasn't entirely clear! I meant that size=None only has to be set whenever the expected results would be affected by the change. In most cases the size=10_000 default acts the same as size=None where it matters.

Thanks to your changes I could also easily see that we were (potentially) doing a lot of extra work in unit tests, retrieving possibly very many results while only caring whether or not we received 50 (or some other number). I also updated those tests to retrieve a more reasonable number of results.

Thanks for the help! You should easily be able to commit my suggested changes (or, if you think this can cause issues, reject them). After that's done I think the PR is good to merge 👍 (see note on progress_rst in comment below)

@PGijsbers
Copy link
Collaborator

For progress_rst I would add a line similar to:

* MAINT #371: ``list_evaluations`` default ``size`` changed from ``None`` to ``10_000``.

under the 11.0 header.

@chouhanaryan
Copy link
Contributor Author

I've made the reqd changes! Let me know if anything else needs to be done 😄

@PGijsbers PGijsbers merged commit f464a2b into openml:develop Oct 24, 2020
@PGijsbers
Copy link
Collaborator

Thank you @chouhanaryan! 🎉

@joaquinvanschoren
Copy link
Contributor

@all-contributors please add @chouhanaryan for code

@allcontributors
Copy link
Contributor

@joaquinvanschoren

I've put up a pull request to add @chouhanaryan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling filters with None

3 participants