-
-
Notifications
You must be signed in to change notification settings - Fork 211
Change default size for list_evaluations #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@PGijsbers Sorry, I'm not entirely sure what to add to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry I wasn't entirely clear! I meant that size=None only has to be set whenever the expected results would be affected by the change. In most cases the size=10_000 default acts the same as size=None where it matters.
Thanks to your changes I could also easily see that we were (potentially) doing a lot of extra work in unit tests, retrieving possibly very many results while only caring whether or not we received 50 (or some other number). I also updated those tests to retrieve a more reasonable number of results.
Thanks for the help! You should easily be able to commit my suggested changes (or, if you think this can cause issues, reject them). After that's done I think the PR is good to merge 👍 (see note on progress_rst in comment below)
|
For under the 11.0 header. |
|
I've made the reqd changes! Let me know if anything else needs to be done 😄 |
|
Thank you @chouhanaryan! 🎉 |
|
@all-contributors please add @chouhanaryan for code |
|
I've put up a pull request to add @chouhanaryan! 🎉 |
Reference Issue
Fixes #371 (partially?)
What does this PR implement/fix? Explain your changes.
Changes default value of parameter
sizeoflist_evaluationsto 10000.How should this PR be tested?
Any other comments?
None.