Class to enum #958
Merged
Class to enum #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
requested changes
Oct 2, 2020
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
Thanks a ton! I think it's nearly ready for a merge, but I'd like to suggest two changes (see the comments):
- the
tasktypesis not defined in the example, which leads to an error - could you also please update the parameter names from
task_type_idtotask_typeto better signal we moved away from using integers in the code?
Contributor
Author
|
I made the changes you said. Not sure about what I should do with the |
PGijsbers
approved these changes
Oct 5, 2020
Collaborator
|
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
To Resolve #951
What does this PR implement/fix? Explain your changes.
This PR converts the TaskTypeEnum class to an enum.Enum object