Increase unit test stability #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by waiting longer for the server to process run traces, and by querying the server less frequently for new run traces.
Collaborator
|
Looks reasonable to me. Waiting for CI reports. |
Collaborator
Author
Doesn't work as well as expected. It fails at one instance where |
actually, we only wait for evaluations to ensure that the trace is processed by the server. Therefore, we can also simply wait for the trace being available instead of relying on the proxy indicator of evaluations being available.
Collaborator
Author
|
Okay, with the latest change it didn't fail for a missing trace any more (there only was one issue with an illegal dataset transition which is not within the scope of this PR which I reran). So in my opinion this is good. (in case travis appears to not be done, please click on the travis link to get to travis-ci.org. It's actually done, but this is not reflected on github) |
Collaborator
|
Annoying, I've had bad connection between travis/github in my gama repo as well. |
PGijsbers
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a lot of unit tests are failing because the server cannot process run traces fast enough. This PR increases the time to wait for a trace to reduce the amount of unit tests failing when using continuous integration.