store uint8 data in uint8 not float #892
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Is there a small dataset to test this or should I mock something? Or any other good ideas for tests? |
Codecov Report
@@ Coverage Diff @@
## develop #892 +/- ##
===========================================
- Coverage 88.57% 88.31% -0.26%
===========================================
Files 37 37
Lines 4324 4332 +8
===========================================
- Hits 3830 3826 -4
- Misses 494 506 +12
Continue to review full report at Codecov.
|
Collaborator
|
Superseded by #983. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #891.
Most of the large datasets in cc-18 are actually "image" dataset with entries from 0-255. Storing them as uint8 will drastically remove the storage space required as well as storing and loading times.
This is special-casing but I think it's a common and important special case. The CIFAR-10 dataset pickle went from 1.4G to 176MB with this patch.