Skip to content

improve sdist handling #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfeurer merged 5 commits into from
Nov 12, 2019
Merged

improve sdist handling #877

mfeurer merged 5 commits into from
Nov 12, 2019

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Nov 11, 2019 •
edited
Loading

@mfeurer mfeurer requested a review from PGijsbers November 11, 2019 14:23
@codecov-io
Copy link

codecov-io commented Nov 11, 2019 •
edited
Loading

Codecov Report

Merging #877 into develop will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #877     +/-   ##
==========================================
- Coverage     88.4%   88.31%   -0.1%     
==========================================
  Files           37       37             
  Lines         4304     4304             
==========================================
- Hits          3805     3801      -4     
- Misses         499      503      +4
Impacted Files Coverage Δ
openml/exceptions.py 83.87% <0%> (-9.68%) ⬇️
openml/runs/functions.py 82.04% <0%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1cfd6e...238d082. Read the comment docs.

@mfeurer mfeurer requested a review from Neeratyoy November 12, 2019 09:45
@mfeurer mfeurer changed the title improve sdsit handling improve sdist handling Nov 12, 2019
@mfeurer mfeurer merged commit a1e2c34 into develop Nov 12, 2019
@mfeurer mfeurer deleted the fix_805_767_865 branch November 12, 2019 10:25
This was referenced Nov 12, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neeratyoy Neeratyoy Neeratyoy approved these changes

@PGijsbers PGijsbers Awaiting requested review from PGijsbers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfeurer @codecov-io @Neeratyoy