-
-
Notifications
You must be signed in to change notification settings - Fork 211
Add debug output #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug output #860
Conversation
| def _check_run(self, run): | ||
| self.assertIsInstance(run, dict) | ||
| self.assertEqual(len(run), 7) | ||
| assert len(run) == 7, str(run) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please explain in comments why 7? is not clear from the (direct) context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the amount of entries per run returned by the API: https://openml.org/api/v1/xml/run/list/flow/1154
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a commit explaining this. I will merge once the tests are through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good. I am not sure if we should really check this, as this is flexible for extension. But in those cases we can adjust the unit tests as well
Codecov Report
@@ Coverage Diff @@
## develop #860 +/- ##
===========================================
+ Coverage 88.36% 88.43% +0.07%
===========================================
Files 37 37
Lines 4272 4272
===========================================
+ Hits 3775 3778 +3
+ Misses 497 494 -3
Continue to review full report at Codecov.
|
to find the cause of previously failing unit tests.