Skip to content

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Oct 29, 2019

to find the cause of previously failing unit tests.

def _check_run(self, run):
self.assertIsInstance(run, dict)
self.assertEqual(len(run), 7)
assert len(run) == 7, str(run)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please explain in comments why 7? is not clear from the (direct) context

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a commit explaining this. I will merge once the tests are through.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good. I am not sure if we should really check this, as this is flexible for extension. But in those cases we can adjust the unit tests as well

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #860 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #860      +/-   ##
===========================================
+ Coverage    88.36%   88.43%   +0.07%     
===========================================
  Files           37       37              
  Lines         4272     4272              
===========================================
+ Hits          3775     3778       +3     
+ Misses         497      494       -3
Impacted Files Coverage Δ
openml/_api_calls.py 85.71% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a13100...aed857f. Read the comment docs.

@Neeratyoy Neeratyoy requested a review from PGijsbers October 30, 2019 13:27
@Neeratyoy Neeratyoy requested a review from PGijsbers October 30, 2019 14:10
@mfeurer mfeurer merged commit 882b06b into develop Nov 4, 2019
@mfeurer mfeurer deleted the add_debug_output branch November 4, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants