Fix 838 #846
Merged
Fix 838 #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #846 +/- ##
==========================================
Coverage ? 88.74%
==========================================
Files ? 37
Lines ? 4942
Branches ? 0
==========================================
Hits ? 4386
Misses ? 556
Partials ? 0
Continue to review full report at Codecov.
|
mfeurer
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #838
What does this PR implement/fix? Explain your changes.
fix list_evaluations_setups to work for evaluations that are not a 100 multiple
How should this PR be tested?
Any other comments?
changed the existing test to get a size that is not a multiple of 100