Skip to content

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Oct 15, 2019

No description provided.

output_format='dataframe',
parameters_in_separate_columns=True,
)
hyperparameters = ['sklearn.svm.classes.SVC(16)_C', 'sklearn.svm.classes.SVC(16)_gamma']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about printing the column names here to show that sklearn.svm.classes.SVC(16)_C & sklearn.svm.classes.SVC(16)_gamma or a check whether it is in the colnames list with the in operator?

Comment on lines 64 to 67
df = openml.evaluations.list_evaluations_setups(
'predictive_accuracy', flow=[8353], task=[6],
output_format='dataframe', parameters_in_separate_columns=True,
) # Choose an SVM flow, for example 8353, and a task.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have the parameters on separate lines to maintain parity with a similar call earlier in the script?

Comment on lines 72 to 74
plt.colorbar(cntr, label="accuracy")
plt.xlim((min(C), max(C))); plt.ylim((min(gamma), max(gamma)))
plt.xlabel("C (log10)"); plt.ylabel("gamma (log10)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be good to have a brief title to the plot.
Also, shouldn't there be a plt.show() for it to come up on the rendered website, and also as a thumbnail on the Examples page?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a title.

The other two are not necessary for the gallery.

Comment on lines 61 to 63
import openml
import numpy as np
import matplotlib.pyplot as plt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could maybe avoid duplicate imports by having a one-time dependency loading at the beginning.

@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@29a023c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #834   +/-   ##
==========================================
  Coverage           ?   89.31%           
==========================================
  Files              ?       36           
  Lines              ?     4718           
  Branches           ?        0           
==========================================
  Hits               ?     4214           
  Misses             ?      504           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a023c...1b96f37. Read the comment docs.

@mfeurer mfeurer requested review from Neeratyoy and amueller October 16, 2019 12:04
@mfeurer mfeurer merged commit c40e474 into develop Oct 16, 2019
@mfeurer mfeurer deleted the svm_hp_tutorial branch October 16, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants