-
-
Notifications
You must be signed in to change notification settings - Fork 211
also check dependencies for sklearn string #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Windows tests are failing (travis probably too, but that's still running): |
mfeurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing unit test.
Codecov Report
@@ Coverage Diff @@
## develop #830 +/- ##
==========================================
Coverage ? 88.02%
==========================================
Files ? 36
Lines ? 4252
Branches ? 0
==========================================
Hits ? 3743
Misses ? 509
Partials ? 0
Continue to review full report at Codecov.
|
Fixes the remainder of #734.
We don't have the model at this point so we can't check the model.