Skip to content

Conversation

@sahithyaravi
Copy link
Member

@sahithyaravi sahithyaravi commented Aug 22, 2019

What does this PR implement/fix? Explain your changes.

Changes to #737 from parameter_name to full name and added option to get parameters in separate columns in case single flow is supplied

How should this PR be tested

evaluations.list_evaluations_setups(function=function,flow=[flow_id], sort_order=sort_order,size=size, output_format='dataframe')

evaluations.list_evaluations_setups(function=function,flow=[flow_id], sort_order=sort_order,size=size, output_format='dataframe', parameters_in_separate_columns = True)

Any other comments?

Previous PR for #737 - #747

@sahithyaravi sahithyaravi requested a review from PGijsbers August 22, 2019 08:32
@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #772 into develop will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #772      +/-   ##
===========================================
- Coverage    87.69%   87.65%   -0.04%     
===========================================
  Files           36       36              
  Lines         4072     4076       +4     
===========================================
+ Hits          3571     3573       +2     
- Misses         501      503       +2
Impacted Files Coverage Δ
openml/evaluations/functions.py 91.57% <66.66%> (-0.73%) ⬇️
openml/runs/functions.py 82.07% <0%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d08c2d...454f297. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants