Skip to content

Conversation

@TwsThomas
Copy link
Contributor

What does this PR implement/fix? Explain your changes.

Pass skipna=False explicitly when calling pd.api.types.infer_dtype to avoid behavioral change and pandas FutureWarning: " A future version of pandas will default to skipna=True. To silence this warning, pass skipna=True|False explicitly."

mfeurer and others added 3 commits February 15, 2019 09:38
pass skipna=False explicitly to avoids pandas FutureWarning: " A future version of pandas will default to `skipna=True`. To silence this warning, pass `skipna=True|False` explicitly."
@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #766 into develop will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #766     +/-   ##
==========================================
- Coverage    87.67%   87.57%   -0.1%     
==========================================
  Files           36       36             
  Lines         4072     4072             
==========================================
- Hits          3570     3566      -4     
- Misses         502      506      +4
Impacted Files Coverage Δ
openml/datasets/functions.py 95.48% <ø> (ø) ⬆️
openml/exceptions.py 84.37% <0%> (-9.38%) ⬇️
openml/runs/functions.py 81.79% <0%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f99118...80e5b33. Read the comment docs.

Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@mfeurer mfeurer merged commit 27521ac into openml:develop Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants