Skip to content

MRG Sklearn 0.21 compatibility and CI #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfeurer merged 19 commits into from
Jul 26, 2019
Merged

MRG Sklearn 0.21 compatibility and CI #752

mfeurer merged 19 commits into from
Jul 26, 2019

Conversation

@amueller
Copy link
Contributor

@amueller amueller commented Jul 25, 2019

Working on #749.

amueller
amueller commented Jul 25, 2019
View reviewed changes
amueller
amueller commented Jul 25, 2019
View reviewed changes
@amueller amueller changed the title WIP Sklearn 0.21 compatibility and CI MRG Sklearn 0.21 compatibility and CI Jul 25, 2019
@amueller
Copy link
Contributor Author

amueller commented Jul 25, 2019

tests pass locally on 0.22.dev0, let's see what CI says

@codecov-io
Copy link

codecov-io commented Jul 25, 2019 •
edited
Loading

Codecov Report

Merging #752 into develop will decrease coverage by 0.08%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #752      +/-   ##
===========================================
- Coverage    87.93%   87.84%   -0.09%     
===========================================
  Files           36       37       +1     
  Lines         4086     4082       -4     
===========================================
- Hits          3593     3586       -7     
- Misses         493      496       +3
Impacted Files Coverage Δ
openml/_backport.py 60% <60%> (ø)
openml/exceptions.py 84.37% <0%> (-9.38%) ⬇️
openml/utils.py 91.13% <0%> (-0.64%) ⬇️
openml/runs/functions.py 81.79% <0%> (-0.29%) ⬇️
openml/flows/flow.py 93.8% <0%> (-0.06%) ⬇️
openml/testing.py 96.38% <0%> (ø) ⬆️
openml/datasets/dataset.py 84.07% <0%> (ø) ⬆️
openml/extensions/sklearn/extension.py 91.32% <0%> (+0.11%) ⬆️
openml/datasets/functions.py 95.48% <0%> (+0.32%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b59cc46...bdbb1f4. Read the comment docs.

@amueller
Copy link
Contributor Author

amueller commented Jul 25, 2019

Not sure what's up with the dict on windows...

mfeurer
mfeurer reviewed Jul 26, 2019
View reviewed changes
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Windows tests use Python3.5, and therefore, you're dicts are not sorted. Could that be the issue?

@mfeurer mfeurer merged commit e6ee09d into openml:develop Jul 26, 2019
@mfeurer mfeurer mentioned this pull request Jul 26, 2019
Closed
@amueller
Copy link
Contributor Author

amueller commented Jul 26, 2019

Thank you! Sweet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfeurer mfeurer mfeurer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amueller @codecov-io @mfeurer