Don't block invocation of python setup.py install
#750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
changed the title
python setup.py install
Collaborator
Yes, the docs were never really updated. It's time for a new release once all tests are continuously green again. |
mfeurer
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #731
Fixes #727
After a discussion on #731, we decided to heed the advice of @pganssle and allow for
setup.py installcalls. Thanks again for chiming in 👍For now we will not check for additional specific conditions which may cause problems. We'll first see what problems users run into (if any).
I decided to open a new PR since changes from the old PR would be undone/unused.
As far as I can tell, the
python setup.py installis not anymore in our documentation. However, a page with this advice is still very much live here. @mfeurer is this a known issue? I thought doc rebuilds were automatically triggered?edit: doh, looks like it is because it refers to master branch docs instead of develop. Still even the master docs should (have) indicate(d) to use pip instead.