Skip to content

Added documentation for creating tasks #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfeurer merged 17 commits into from
Jul 26, 2019
Merged

Added documentation for creating tasks #719

mfeurer merged 17 commits into from
Jul 26, 2019

Conversation

@joaquinvanschoren
Copy link
Contributor

@joaquinvanschoren joaquinvanschoren commented Jun 21, 2019

Documents the task upload functionality.

@codecov-io
Copy link

codecov-io commented Jun 21, 2019 •
edited
Loading

Codecov Report

Merging #719 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #719   +/-   ##
======================================
  Coverage       88%    88%           
======================================
  Files           36     36           
  Lines         4077   4077           
======================================
  Hits          3588   3588           
  Misses         489    489

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c806b...01e63d5. Read the comment docs.

@PGijsbers
Copy link
Collaborator

PGijsbers commented Jun 28, 2019

Is this PR ready for review?

mfeurer
mfeurer requested changes Jul 8, 2019
View reviewed changes
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this example. In general this looks good and I left a few remarks here and there. The only real issue right now is that it does not execute on the test server. Could you please have a look into that?

@joaquinvanschoren
Copy link
Contributor Author

joaquinvanschoren commented Jul 10, 2019

Ehm, tests now fail becausepytest: error: unrecognized arguments: --duration=20
What's up with that?

Also, when you said "it does not execute on the test server", did you mean that the test fails or it doesn't even get executed? Do I need to register it somewhere?

@PGijsbers
Copy link
Collaborator

PGijsbers commented Jul 10, 2019

Ehm, tests now fail becausepytest: error: unrecognized arguments: --duration=20
What's up with that?

This is fixed on develop. It has to do with an upgrade to Pytest 5.0, see #728. I'm not sure if it's better to merge with develop or just cherry-pick f66c27c (@mfeurer).

@mfeurer
Copy link
Collaborator

mfeurer commented Jul 15, 2019

I'm not sure if it's better to merge with develop or just cherry-pick

I'd prefer rebase, but merging the development branch into this branch should also be fine.

mfeurer
mfeurer reviewed Jul 15, 2019
View reviewed changes
mfeurer
mfeurer reviewed Jul 15, 2019
View reviewed changes
@mfeurer
Copy link
Collaborator

mfeurer commented Jul 15, 2019

Looks good overall, I'd be happy to merge once the tests pass

@mfeurer mfeurer mentioned this pull request Jul 19, 2019
Closed
@Neeratyoy Neeratyoy self-assigned this Jul 24, 2019
@Neeratyoy Neeratyoy requested a review from mfeurer July 25, 2019 12:25
mfeurer
mfeurer reviewed Jul 25, 2019
View reviewed changes
@Neeratyoy Neeratyoy requested a review from mfeurer July 25, 2019 14:51
@mfeurer mfeurer merged commit 1f5d6a2 into develop Jul 26, 2019
@mfeurer mfeurer deleted the joaquinvanschoren-patch-1 branch July 26, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neeratyoy Neeratyoy Neeratyoy left review comments

@mfeurer mfeurer mfeurer approved these changes

Assignees

@Neeratyoy Neeratyoy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joaquinvanschoren @codecov-io @PGijsbers @mfeurer @Neeratyoy