-
-
Notifications
You must be signed in to change notification settings - Fork 211
Release version 0.9 #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Release version 0.9 #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* more tasks * cleanup and fixes * tasks fixes * added missing return * added learning curve task * fixed import * added 2.7 compatibility * typos * first implementation of regression and clustering * added test function * cleaning and bugfixing * cleaning and bugfixing * unit test implemented plus many extensions for regression * trying to fix travis build issues * PEP8 fixes * more PEP8 fixes * more PEP8 fixes * more PEP8 fixes * more PEP8 fixes * fix merge issue * fix merge issue * last PEP8 fix * very last PEP8 fix * avoiding run-already-exists errors * added documentation for running specific tests * cleanup * added missing import * merge with develop + fixes * code cleanup and PEP8 fixes * please flake * please matthias * bugfix * fix merge issues * fix merge issues * please flake again * PEP8 * PEP8 * PEP8 * PEP8 * More PEP8 * More PEP8 * simplify unit test * PEP8 * PEP8 * Undo syntax error
* MAINT remove python2 support * MAINT reduce the amount of warnings * MAINT PEP8 * MAINT improve style
* added study create * redesigns api call function to put the responsibility which HTTP request to perform with the user * added benchmark suite functionality * added request method to read url function * fixing unit tests * PEP8 fixes * adds deletion * removes left over prints * study functions * PEP8 fix * pep8 fix * all run ids * addresses main points of review * typo fix * knowledge type -> entity type * additional check * PEP8 fixes (I) * fix PEP8 (II) * PEP8 (III) * replaced study delete with status update * finalized PR
* PEP8. No unused import. # always follows by space. * PEP8 * Edit a blank line back in for file formatting. * PEP8. Fix grammar. * PEP8 * PEP8. * PEP8 * Refactor. * PEP8, small refactor. * OpenMLStudy available through import * * PEP8. * PEP8. * PEP8. Removed Py2 support. * PEP8. * PEP8. Minor refactor. * PEP8. Refactor/bugfix __eq__ * PEP8. task type are input for list_tasks anyway, so the enum should be exposed. * PEP8. * undo linebreaks * Update for updated error message. * Update for updated error message. * Undo refactor. * Redo refactor. * Fix syntax error due to online merging * Fix merge error due to online merging * Fix bug due to online merge error * Change flake scope and arguments. * Final PEP8 changes. * PEP8 for several test files * PEP8. * PEP8. * PEP8. Removed import 'unused' import statements. Have to watch unit tests. * Fix bug regarding not existing argument * PEP8. * Flake8 ignore directive.
Faster tests on AppVeyor
* PEP8 remove pep8 violations * Typo.
…e (bool, float, int, str)
* Add support for serializing numpy data types. * Added tests on numpy-types in sklearn_to_flow.
* Documentation fix * Add doc for run_model_on_task * Initial additions * Added functions to cache flows * Tweaking a function from flow which will be used to create a task dict as a pre step for publish * Undo 22b1e62. * PEP8 compliance. * Add (unused) flag to (not) upload flow. Rename get_seeded_model method as the name did not reflect the functionality. * Add RunExistsError. * RunsExistsError now correctly allows multiple runs, reflected in name. * Towards offline run_model_on_task * Fix name. * Py3 style. * Fix typo. * Allow run flow locally. Caching and upload not implemented. * Clean up test with new Error type. * Check if flow exists before uploading. * Remove one-line method that was only called from other method. * Change error type. Add typehint. * Fix imports. * Publish flow if flow_id is None. * Do not allow for mutable parameter. * Fill in parameter_settings based on the referenced flow. * Allow parameters to be extracted for model which is not part of the object. * Can not use reinstantiated model. * to/from filesystem methods. * When (de)serializing, if a local flow was used, also (de)serialize the flow. * When loading a locally stored run, do not force fields for which the flow is required to have been uploaded. * Updated publish_error for new publish. * Use mock for existing_flow * Add documentation on the offline functionality. * Disable two unit tests for now. * Fix typo. * PEP8. * Remove old check. * Update to reflect the change that uploading the flow is no longer default behavior. * Fixed an error where non-existant flows still got the treatment to check for duplicates. * Make tests actually fully local. Update for new parameter order. * Type hints. Explicitly check for int rather than implicit cast of int to bool. * Add errors for inconsistencies between local flows and server information. * Now only sets hyperparameters if sync happened. * Always sync with server if we know the flow to exist on the server. * Update vanilla test. Add test for local flow upload after file stored to disk. * Raise an error if `flow.publish` is called on a flow with different local id than the one known on the server. * Add tests to verify identical behavior if run is loaded from disk instead. * Line too long. * Docs, typehint. Remove unused method publish_flow_is_necessary. * Changed summary as suggested by @mfeurer. * Type hints. * Fix naming inconsistency between from_filesystem and to_filesystem. * Updated for the new parametername. * Function signature formatting improvements. * Consistent spacing around colons. Add parameter description of `from_server` * Add missing parenthesis. * Doc changes, typehint. * Remove check for flow as I think it is outdated. * PrivateDatasetError and RunsExistError now prefixed with 'OpenML' * Updated unit test to verify flows existence before/after run_model_on_task and publish. * Start for testing model on downloaded flow. * Explicit test for none as other __len__ can get invoked on some models to test for truthiness. * Unit test now downloads flow after ensuring it exists. * Test with run_flow_on_task instead so a sentinel can be added to the flow to ensure it does not exist on the server. * Fixed a bug where run.flow_id would be set to False instead of None if associated flow did not exist but was also not uploaded. This gave errors at publish-time. * Fix typo.
…loading (#548) * EHN: add support for DataFrame when loading dataset * MAINT: add pandas as dependency * FIX: typo in setup * TST: add unit test for checking pandas and numpy * FIX: back-compatibility defaulting on float 32 * PEP8 * FIX: transform y to integer if a category for back-compat * PEP8 * DOC: add example * TST: remove useless tests * iter * iter * iter * EHN: partially address mfeurer comments * FIX: append column and concat * simplify * FIX: add back missing test files * CLEAN: remove new useless pkl * FIX: revert backward compatibility * PEP8 * PEP8 * fix * TST: ensure behavior of ignore_attribute * TST: add test for SparseDataFrame * raise FutureWarning and avoid warning in testing * EHN: interpret propely the boolean type * FIX typo * PEP8 * MAINT: show slowest tests * FIX: avoid reallocation in a loop with pandas * fix typo * fixes
* Provide easier switching to an example configuration, so that users can perform the examples. * Fixed as use of local variables did not work. * Refactor into class to avoid introducing new global variables. * Prevent users from accidentally discarding old configurations. Unit tests to check proper behavior. * Rename to ConfigurationForExamples * Renamed class as it the same due to copy pasta. * rename functions
Added notice to all examples for using the test server. Use test serv…
Improve extension interface
* Initial implementation * Further progress on task upload * changes to pr * Code refactor, implementation changed * pep8 fix * Fix * Update for the errors only on travis-ci * Fix for failing builds * Fixes in accordance with openml * Refactor and changes * Changes considering the suggestions from Matthias * Updating clustering tasks to bypass the issue * Refactoring and bug fixes * Flake fix and considering another task for classification * Changing the ClassificationTask to the test server * Testing simple solution * Addressing the comments from Matthias * Fixing unused imports * Addressing #656 * Addressing #657 * Addressing the comments from Matthias, refactoring the task classes * Update pr * Trying fix for task upload * Fix bug introduced from previous changes on perform_api_call, increase max_wait_time for task upload * Update code, increase max time for task upload * Increasing wait time for task upload * Further increase in max wait time * Added create_task function, changed the implementation for the unit tests regarding task upload * Overcoming different feature types bug * Type annotations errors * Fixing pep8 spacing * Update 1 * Update 2 * Fixing type annotations * Another try at fixing type annotations for tasks * Fixing bug with unit tests of clustering tasks, changing order for type annotations * Fix for type annotations * Update for type annotations and failing clustering tasks * Further refactoring * Important refactor * Pep8 fix * Trying change * Trying fix for overload of setUp function * Update induced bug * Trying solution for unittest inheritance * Partially addressing the comments from Matthias, pep8 fix * Addressing the comments from Matthias and a first try at the pep8 run issue * Fixing pep8 errors * Enforcing pep8 * Another try at pep8 solution * Pep8 Fix * Address type annotation warnings * pep8 fix * addressing type annotations v2 * Addressing the comments from Matthias * Minor refactor * Testing 2 possible cases of uploading a clustering task
* Make more explicit splitting. * Always return four values. * Update function signature. Update dataformat to expected 0.9 behavior. * Stashing changes. WIP update tests. * PEP8 says not to test boolean values with 'is'. * Fix ignore_row_attribute test. * Streamline if-else flow for excluding attributes. * Update doc to reflect multiple targets is not supported. * Updated all tests. * Updated other calls. * Fix sparse tests. * Flake8. * Feedback mfeurer. * Parameter not Optional.
* Adding dataframe output option to listing functions * Adding 'object' as new output format for listing * Editing examples for dataframe output option * Implementing coding standards as per suggestions. * Adding test cases for listing as dataframe * Convert list to List * Fixing rebase bugs, flake errors and test cases * Fixing new unit test for flow * Fixing bug in unit test for flow * Fixing test case bug * Update functions.py * Update functions.py * Update functions.py
* Changelog update, minor template updates. * Add update to changelog
* Adding example file for evaluations * Adding example file for evaluations * Adding boxplot to compare flows * Editing example headers for make html * Renaming file for make html * Adding more comments, describing plot * Fixing typos, plot aesthetics * Adding flow ID to flow name mapping; Minor text changes * Minor simplification in boxplot function * Fixing PEP8 whitespace issue
* Removing dependency on scipy arff * Cleaning code * Loading arff as generator object * Removing redundant decode * PEP8
* fix bugs, use live server due to reduced volatility * use older scipy version for older sklearn version * fix bash syntax error * add --yes to conda install * Remove print statement
* Adding status_update to datasets api * Adding assert_flows_equals to flows api * Updating init for runs * Adding run_exists for runs api * Adding study and extensions api * Adding OpenMLSetup and OpenMLParameter to top-level class docu * Adding docstrings * Debugging for missing documentation * Adding class docstrings * Addressing descriptor docstrings + adding Study object docstrings * Updating PR template + Adding missing class from study to api * Fixing typo in api.rst * Changes to docstrings * Removing BaseStudy from import
Fixes a bug which makes sure that uploading a task does not fail due to the task already existing on the test server.
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
=========================================
+ Coverage 89.76% 90.36% +0.6%
=========================================
Files 32 36 +4
Lines 3077 3789 +712
=========================================
+ Hits 2762 3424 +662
- Misses 315 365 +50
Continue to review full report at Codecov.
|
PGijsbers
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.