Fix bugs by using live server due to reduced volatility #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
(tests pass on appveyor, presumably due to a different scipy version used for Windows) |
Codecov Report
@@ Coverage Diff @@
## develop #698 +/- ##
===========================================
- Coverage 90.35% 90.33% -0.03%
===========================================
Files 36 36
Lines 3785 3787 +2
===========================================
+ Hits 3420 3421 +1
- Misses 365 366 +1
Continue to review full report at Codecov.
|
Collaborator
|
What's the reason for not merging in the latest version of dev (with mentioned fix)? |
Collaborator
Author
|
Actually none, except that I'm not a fan of merging. The PR checks are green now, which should give us enough confidence that this PR does what it's supposed to do. |
PGijsbers
approved these changes
May 29, 2019
| openml.config.server = self.production_server | ||
| flow_id = 6794 | ||
| setups = openml.setups.list_setups(flow=flow_id, output_format='object', size=10) | ||
| print(setups) |
Collaborator
There was a problem hiding this comment.
Why is the print statement here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs which were 'introduced' recently by data changes on the test server. This does not include the fix included in #693 and will therefore not fix all unit tests.