Added notice to all examples for using the test server. Use test serv… #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This was intended to be a draft >.> not sure what happened there |
Codecov Report
@@ Coverage Diff @@
## develop #684 +/- ##
========================================
Coverage 90.76% 90.76%
========================================
Files 36 36
Lines 3650 3650
========================================
Hits 3313 3313
Misses 337 337Continue to review full report at Codecov.
|
mfeurer
approved these changes
Apr 19, 2019
Collaborator
|
@PGijsbers I added your suggestions. Could you please check the changes I made? |
Collaborator
Author
|
Looks good. I'm merging this so that we can then update examples with individual PRs as necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the #680 functionality and adds warning messages that the test server is used for examples.
Unfortunately I probably won't have the time to finish this before the weekend (and I won't have time to work on it then, either). Feel free to take over this PR.