Easy access test server #680
Conversation
|
I cancelled the |
Codecov Report
@@ Coverage Diff @@
## develop #680 +/- ##
===========================================
+ Coverage 90.82% 91.17% +0.35%
===========================================
Files 36 36
Lines 3573 3897 +324
===========================================
+ Hits 3245 3553 +308
- Misses 328 344 +16
Continue to review full report at Codecov.
|
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Thanks a lot, this all looks great, but I have a remark about the naming. ExampleConfiguration reads like it is an example for the configuration, but it actually is the configuration for the examples. Could you please switch the order of the two in the class name and all the function names?
|
Changed it, but to |
openml/config.py
Outdated
| cache_directory = cachedir | ||
|
|
||
|
|
||
| start_use_example_configuration = ConfigurationForExamples.start_use_example_configuration |
There was a problem hiding this comment.
Sorry for not being specific enough, could you please also change the name of these functions to make their use clearer?
|
Taking over this PR. |
Two functions which make it easier to switch between a test environment and a production environment.
This is so we can create examples which operate on the test server and upload things, and have them easily be reproducible for people trying to follow the examples.
In the old style, you would have to set the server and apikey yourself. This is a little bit more verbose, possibly requires having to look up what the apikey is, and having the apikey in more plain sight.
With the changes we can instead use:
The apikey for the test server is from the openml tutorials, and is different from the one we use for unit testing. This is in the event we later need to purge specific subset of data from the test server (e.g. we find someone abused the example apikey and it is affecting unit tests).
Yay or nay?
I'll add a unit test if the concept is approved.