[MRG] Fix402 #677
Merged
[MRG] Fix402 #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #677 +/- ##
==========================================
- Coverage 90.54% 90.5% -0.04%
==========================================
Files 36 36
Lines 3743 3730 -13
==========================================
- Hits 3389 3376 -13
Misses 354 354
Continue to review full report at Codecov.
|
mfeurer
reviewed
Apr 29, 2019
mfeurer
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes:
dataset.get_datanow always returns a quaternary tuple ofdata, targets, categorical, attribute names.FutureWarningfor moving topd.DataFrameand adjust default behavior.Second contribution and related test updates really should have been a separate PR.
I am sorry for putting it into one, it kinda happened.
Closes #402.
Will need to create a new issue, because I removed this TODO (all TODOs should rather be centralized on the issue tracker, right?).