Add support for serializing numpy data types. #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #635 +/- ##
===========================================
- Coverage 90.12% 89.86% -0.27%
===========================================
Files 32 32
Lines 3232 3236 +4
===========================================
- Hits 2913 2908 -5
- Misses 319 328 +9
Continue to review full report at Codecov.
|
mfeurer
reviewed
Mar 4, 2019
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Looks good, could you please add a unit test ensuring the behavior and also add a check that numpy arrays cannot be serialized?
Collaborator
Author
|
@mfeurer I assumed you would get a ping automatically, but I am not sure if this is the case. I added the tests. |
Collaborator
|
I get a ping for a commit, but I usually do not check the commits because I don't know if that commit makes it ready for review again. Will check now. |
mfeurer
approved these changes
Mar 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes on the fix in #304.