Skip to content

Finish pep8 compliance #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfeurer merged 2 commits into from
Feb 25, 2019
Merged

Finish pep8 compliance #630

mfeurer merged 2 commits into from
Feb 25, 2019

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Feb 24, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 24, 2019 •
edited
Loading

Codecov Report

Merging #630 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #630   +/-   ##
========================================
  Coverage    89.86%   89.86%           
========================================
  Files           32       32           
  Lines         3208     3208           
========================================
  Hits          2883     2883           
  Misses         325      325
Impacted Files Coverage Δ
openml/datasets/__init__.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c1edd...7e7949e. Read the comment docs.

janvanrijn
janvanrijn reviewed Feb 24, 2019
View reviewed changes
Copy link
Member

@janvanrijn janvanrijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks mainly great to me. Can you explain why the script flake8_diff.sh used to be huge, and is now only 3 lines? (Which is great btw)

I have some guessed but would be good to see this confirmed.

@mfeurer
Copy link
Collaborator Author

mfeurer commented Feb 25, 2019

The script was huge because it performed flake8 on the difference between the latest commit and the common ancestor between the current branch and the development branch. These differences had to be fetched and assembled. Now the script simply checks everything.

PGijsbers
PGijsbers reviewed Feb 25, 2019
View reviewed changes
PGijsbers
PGijsbers reviewed Feb 25, 2019
View reviewed changes
@PGijsbers PGijsbers mentioned this pull request Feb 25, 2019
Closed
@mfeurer mfeurer merged commit 0980673 into develop Feb 25, 2019
@mfeurer mfeurer deleted the finish_pep8 branch February 25, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janvanrijn janvanrijn janvanrijn left review comments

@PGijsbers PGijsbers PGijsbers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mfeurer @codecov-io @janvanrijn @PGijsbers