MAINT remove python2 support #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #623 +/- ##
==========================================
Coverage ? 89.68%
==========================================
Files ? 32
Lines ? 3123
Branches ? 0
==========================================
Hits ? 2801
Misses ? 322
Partials ? 0
Continue to review full report at Codecov.
|
janvanrijn
reviewed
Feb 19, 2019
| flow, _ = self._add_sentinel_to_flow_name(flow, None) | ||
| flow.publish() | ||
| self.assertRaisesRegexp(openml.exceptions.OpenMLServerException, | ||
| self.assertRaisesRegex(openml.exceptions.OpenMLServerException, |
janvanrijn
reviewed
Feb 19, 2019
tests/test_flows/test_sklearn.py
Outdated
|
|
||
| self.assertRaisesRegexp(ValueError, msg, | ||
| self.assertRaisesRegex(ValueError, msg, | ||
| openml.flows.obtain_parameter_values, flow) |
janvanrijn
reviewed
Feb 19, 2019
tests/test_flows/test_sklearn.py
Outdated
| flow = sklearn_to_flow(model) | ||
| flow.flow_id = 1 | ||
| self.assertRaisesRegexp(ValueError, msg, | ||
| self.assertRaisesRegex(ValueError, msg, |
janvanrijn
reviewed
Feb 19, 2019
| 'flow_exists' | ||
| self.assertRaisesRegexp(ValueError, expected_message_regex, | ||
| self.assertRaisesRegex(ValueError, expected_message_regex, | ||
| openml.runs.run_flow_on_task, |
janvanrijn
reviewed
Feb 19, 2019
tests/test_tasks/test_split.py
Outdated
| self.assertEqual(train_split.shape[0], 808) | ||
| self.assertEqual(test_split.shape[0], 90) | ||
| self.assertRaisesRegexp(ValueError, "Repeat 10 not known", | ||
| self.assertRaisesRegex(ValueError, "Repeat 10 not known", |
janvanrijn
reviewed
Feb 19, 2019
tests/test_tasks/test_split.py
Outdated
| split.get, 10, 2) | ||
| self.assertRaisesRegexp(ValueError, "Fold 10 not known", | ||
| self.assertRaisesRegex(ValueError, "Fold 10 not known", | ||
| split.get, 2, 10) |
janvanrijn
reviewed
Feb 19, 2019
tests/test_tasks/test_task.py
Outdated
| self.assertEqual(24, test_indices[-1]) | ||
| self.assertRaisesRegexp(ValueError, "Fold 10 not known", | ||
| self.assertRaisesRegex(ValueError, "Fold 10 not known", | ||
| task.get_train_test_split_indices, 10, 0) |
janvanrijn
reviewed
Feb 19, 2019
tests/test_tasks/test_task.py
Outdated
| task.get_train_test_split_indices, 10, 0) | ||
| self.assertRaisesRegexp(ValueError, "Repeat 10 not known", | ||
| self.assertRaisesRegex(ValueError, "Repeat 10 not known", | ||
| task.get_train_test_split_indices, 0, 10) |
janvanrijn
reviewed
Feb 19, 2019
| openml.config.cache_directory = self.static_cache_dir | ||
| self.assertRaisesRegexp(OpenMLCacheException, | ||
| self.assertRaisesRegex(OpenMLCacheException, | ||
| 'Task file for tid 2 not cached', |
janvanrijn
approved these changes
Feb 19, 2019
Member
janvanrijn
left a comment
janvanrijn
left a comment
There was a problem hiding this comment.
I am happy with the code in its current state. Can be merged if all checks are green.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes python 2 support and reduces the number of warnings emitted when running unit tests.