Codecov Report

Merging #620 into develop will increase coverage by 0.29%.
The diff coverage is 96.99%.

@@             Coverage Diff             @@
##           develop     #620      +/-   ##
===========================================
+ Coverage    89.59%   89.88%   +0.29%     
===========================================
  Files           32       32              
  Lines         3123     3193      +70     
===========================================
+ Hits          2798     2870      +72     
+ Misses         325      323       -2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96db525...bb0161a. Read the comment docs.

Looks good to me. Except that one line which basically says to not merge this PR.

And it seems there are some minor flake8 errors in the push test. I really don't know what to do with the flake8 errors in the PR test as they are so many and would only happen after the merge.

Looks good to me. Except that one line which basically says to not merge this PR.

we need to wait for the PHP PR to be merged.

And it seems there are some minor flake8 errors in the push test. I really don't know what to do with the flake8 errors in the PR test as they are so many and would only happen after the merge.

Bigger issue: some lines are OK, other still contain mistakes (legacy mistakes, and we don't really want to solve them all at once)

Clearly it would be beneficial to have the whole project flake compatible. We can maybe ask the programmer to do so on one of the first days? (Once all big PR's are merged) From there on flake can run on all lines, not just the diff, and we don't have these problems anymore.

The problems introduced in this PR will be fixed by me.

openml/study/__init__.py:2:1: F401 '.functions.get_study' imported but unused
from .functions import get_study, create_study, create_benchmark_suite, \
^
openml/study/__init__.py:2:1: F401 '.functions.create_study' imported but unused
from .functions import get_study, create_study, create_benchmark_suite, \
^
openml/study/__init__.py:2:1: F401 '.functions.create_benchmark_suite' imported but unused
from .functions import get_study, create_study, create_benchmark_suite, \
^
openml/study/__init__.py:2:1: F401 '.functions.delete_study' imported but unused
from .functions import get_study, create_study, create_benchmark_suite, \
^
openml/study/__init__.py:2:1: F401 '.functions.attach_to_study' imported but unused
from .functions import get_study, create_study, create_benchmark_suite, \
^
openml/study/__init__.py:2:1: F401 '.functions.detach_from_study' imported but unused
from .functions import get_study, create_study, create_benchmark_suite, \

flake8 residuals. this is fine right? Can we inform it that this warning in __init__ files is OK?

Looks good to me except for the failing unit tests.