Fix602 #615
Fix602 #615
Conversation
incorporated test case according to #602
Codecov Report
@@ Coverage Diff @@
## develop #615 +/- ##
===========================================
- Coverage 89.87% 89.81% -0.06%
===========================================
Files 32 32
Lines 3031 3053 +22
===========================================
+ Hits 2724 2742 +18
- Misses 307 311 +4
Continue to review full report at Codecov.
|
| # Only in Python 3.x, as Python 2 has Unicode issues | ||
| if sys.version_info[0] >= 3: | ||
| self.assertEqual(str(model.get_params()), | ||
| str(new_model.get_params())) |
There was a problem hiding this comment.
A few lines below there's the check self.assertEqual(new_model.get_params(), model.get_params()). Is there a reason to not use that?
There was a problem hiding this comment.
Also, in flow.functions there's a function called assert_flows_equal, would that be helpful in this context and potentially replace a few checks?
There was a problem hiding this comment.
I think this question basically holds for all future occurences of this check. Maybe you could also group all checks into a separate function?
Stores information about ColumnTransformer in setup, so it can be reinstantiated without problems across tasks.