Skip to content

[WIP] Task upload #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfeurer merged 57 commits into from
Apr 26, 2019
Merged

[WIP] Task upload #607

mfeurer merged 57 commits into from
Apr 26, 2019

Conversation

@ArlindKadra
Copy link
Member

@ArlindKadra ArlindKadra commented Dec 8, 2018 •
edited
Loading

What does this PR implement/fix? Explain your changes.

  • Implements task upload.

    1. Generates dictionary that represents object.
    2. Generates xml from the dictionary.

  • Adds a function that allows tasks to be created (facilitates task creation for users compared to the task constructor).

  • Adds type annotations for the task object.

How should this PR be tested?

New unit tests for different kinds of tasks.

Addresses #657, #656

@codecov-io
Copy link

codecov-io commented Jan 29, 2019 •
edited
Loading

Codecov Report

Merging #607 into develop will decrease coverage by 0.13%.
The diff coverage is 86.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #607      +/-   ##
===========================================
- Coverage    90.67%   90.54%   -0.14%     
===========================================
  Files           36       36              
  Lines         3690     3743      +53     
===========================================
+ Hits          3346     3389      +43     
- Misses         344      354      +10
Impacted Files Coverage Δ
openml/datasets/dataset.py 88.58% <100%> (+0.03%) ⬆️
openml/tasks/__init__.py 100% <100%> (ø) ⬆️
openml/extensions/sklearn/extension.py 90.62% <64.28%> (-0.25%) ⬇️
openml/runs/functions.py 81.5% <75%> (-0.37%) ⬇️
openml/tasks/functions.py 85.09% <83.33%> (-0.07%) ⬇️
openml/runs/run.py 89.65% <83.33%> (-0.51%) ⬇️
openml/tasks/task.py 94.77% <93.65%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f656062...6e70b83. Read the comment docs.

@ArlindKadra ArlindKadra requested review from mfeurer and removed request for mfeurer February 7, 2019 21:08
mfeurer
mfeurer reviewed Feb 11, 2019
View reviewed changes
@ArlindKadra ArlindKadra mentioned this pull request Feb 21, 2019
Merged
mfeurer
mfeurer reviewed Mar 27, 2019
View reviewed changes
openml/tasks/task.py Outdated
task_container = super(OpenMLClusteringTask, self)._to_dict()
task_dict = task_container['oml:task_inputs']

task_dict['oml:input'].append(
Copy link
Collaborator

@mfeurer mfeurer Mar 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the estimation procedure common to all task types? If yes, could you please add it to the parent class?

Copy link
Member Author

@ArlindKadra ArlindKadra Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice observation. It also made me realise that the code for some of the tasks can be incomplete since when the class is downloaded from the server it has more information concerning the estimation procedure.

@PGijsbers PGijsbers mentioned this pull request Apr 15, 2019
Closed
@ArlindKadra ArlindKadra mentioned this pull request Apr 15, 2019
Closed
mfeurer
mfeurer reviewed Apr 19, 2019
View reviewed changes
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks really good! Only a few minor comments. I'll approve once the PEP8 stuff is green.

@ArlindKadra ArlindKadra requested a review from mfeurer April 24, 2019 19:02
mfeurer
mfeurer reviewed Apr 25, 2019
View reviewed changes
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I just have a few minor questions/requests, and then we should be good to go with this!

@ArlindKadra ArlindKadra requested a review from mfeurer April 26, 2019 09:50
@mfeurer mfeurer merged commit 813daeb into develop Apr 26, 2019
@mfeurer mfeurer deleted the task_upload branch April 26, 2019 10:34
This was referenced Apr 26, 2019
Closed
Closed
@mfeurer mfeurer mentioned this pull request Apr 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfeurer mfeurer mfeurer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArlindKadra @codecov-io @mfeurer