Skip to content

Fix #569: crash when sklearn version does not collide #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfeurer merged 4 commits into from
Dec 7, 2018
Merged

Fix #569: crash when sklearn version does not collide #601

mfeurer merged 4 commits into from
Dec 7, 2018

Conversation

@janvanrijn
Copy link
Member

@janvanrijn janvanrijn commented Dec 5, 2018

fixes #569

@janvanrijn janvanrijn requested a review from mfeurer December 5, 2018 19:17
@janvanrijn janvanrijn changed the base branch from master to develop December 5, 2018 19:17
@codecov-io
Copy link

codecov-io commented Dec 5, 2018 •
edited
Loading

Codecov Report

Merging #601 into develop will decrease coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #601      +/-   ##
=========================================
- Coverage    90.06%    90%   -0.07%     
=========================================
  Files           32     32              
  Lines         3001   3000       -1     
=========================================
- Hits          2703   2700       -3     
- Misses         298    300       +2
Impacted Files Coverage Δ
openml/flows/flow.py 95.07% <ø> (-0.17%) ⬇️
openml/flows/functions.py 93.33% <80%> (-0.86%) ⬇️
openml/flows/sklearn_converter.py 91.37% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d61c4...78db15a. Read the comment docs.

@mfeurer
Copy link
Collaborator

mfeurer commented Dec 6, 2018

Does this also fix #485?

@janvanrijn
Copy link
Member Author

janvanrijn commented Dec 6, 2018

I think #485 and this issue are duplicates. #485 is badly described though (you can actually get flows from other workbenches)

@mfeurer mfeurer merged commit 04c4d0e into develop Dec 7, 2018
This was referenced Dec 7, 2018
Closed
Closed
@janvanrijn janvanrijn deleted the fix_#569 branch December 11, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfeurer mfeurer mfeurer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

get_flow crashes when downloading a flow from a different sklearn version

4 participants

@janvanrijn @codecov-io @mfeurer