Skip to content

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Dec 4, 2018

This PR prepares a new release.

@janvanrijn
Copy link
Member

Can we try to have #567 in the release as well? I can contribute the example today

@glemaitre
Copy link
Contributor

What is the release schedule. I'll like to have #548 as well and I am willing to finish it up right away.

@mfeurer
Copy link
Collaborator Author

mfeurer commented Dec 4, 2018

There's not really a release schedule yet and there's no hurry at all. My motivation was to get things out as it has been a while since the last release and there have been multiple new issues for problems which we have already solved in the development branch. Therefore, I'm happy to wait for both PRs to have a nice and consistent release. However, it would be great to get this done within the next few days.

@joaquinvanschoren
Copy link
Contributor

Regression (#560) as well please :)

@mfeurer
Copy link
Collaborator Author

mfeurer commented Dec 4, 2018

What's the current status of #560? I know that the other two are almost done, but I did not follow the regression PR.

@joaquinvanschoren
Copy link
Contributor

It was done, and we did the requested change to enums.
There were some merge conflicts because develop changed. I resolved those, but tests are now failing because of an import error. Looking into that now.

@janvanrijn
Copy link
Member

Cool! Let me know when #560 is ready for review and I will go through it again.

@janvanrijn
Copy link
Member

Another pretty important issue that should definitely be solved: #569

I will create a PR tomorrow.

@mfeurer
Copy link
Collaborator Author

mfeurer commented Feb 11, 2019

ping @janvanrijn

@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #600 into develop will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #600      +/-   ##
===========================================
- Coverage     89.9%   89.87%   -0.04%     
===========================================
  Files           32       32              
  Lines         3031     3031              
===========================================
- Hits          2725     2724       -1     
- Misses         306      307       +1
Impacted Files Coverage Δ
openml/__version__.py 100% <100%> (ø) ⬆️
openml/runs/functions.py 87.3% <0%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e69fe0...ed51989. Read the comment docs.

Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mfeurer mfeurer merged commit b71325c into develop Feb 13, 2019
@mfeurer mfeurer deleted the release_0_8 branch February 13, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants