[MRG] DEPR: remove the format parameter from create_dataset #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
reviewed
Nov 16, 2018
| ) | ||
| elif isinstance(data, coo_matrix): | ||
| d_format = 'sparse_arff' | ||
| if isinstance(data, (list, np.ndarray)): |
Collaborator
There was a problem hiding this comment.
Hm, don't you need to ckeck for pd.DataFrame and pd.SparseDataFrame, too?
Contributor
Author
|
I will fix this PR after merging #583 |
Contributor
Author
|
This should be ok now |
mfeurer
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mentioned in #586 that
formatcould be deprecated even if it is breaking the backward compatibility:#586 (comment)
It is what this PR is doing.