Refactoring tasks #588
Merged
Refactoring tasks #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
approved these changes
Nov 13, 2018
glemaitre
pushed a commit
to glemaitre/openml-python
that referenced
this pull request
Nov 16, 2018
mfeurer
pushed a commit
that referenced
this pull request
Nov 16, 2018
* EHN: support SparseDataFrame when creating a dataset * TST: check attributes inference dtype * PEP8 * EXA: add sparse dataframe in the example * Fix typos. * Fix typo. * Refactoring task.py (#588) * [MRG] EHN: inferred row_id_attribute from dataframe to create a dataset (#586) * EHN: inferred row_id_attribute from dataframe to create a dataset * reset the index of dataframe after inference * TST: check the size of the dataset * PEP8 * TST: check that an error is raised when row_id_attributes is not a known attribute * DOC: Update the docstring * PEP8 * add examples to the menu, remove double progress (#554) * PEP8 * PEP8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#587
What does this PR implement/fix? Explain your changes.
It refactors task.py since it does not make full use of inheritance.
How should this PR be tested?
Existing unit tests.