[MRG] EHN: support SparseDataFrame when creating a dataset #583
Conversation
|
@amueller @mfeurer @janvanrijn Here come the support for sparse dataframe during dataset creation. |
|
ping @amueller @mfeurer @janvanrijn any feedback? |
|
Personally, I am not super familiar with sparse dataframes. I can have a look at your test-cases if you'd like and see whether they cover interesting test-cases. |
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
This looks good to me. Could you add this to the example, too?
Codecov Report
@@ Coverage Diff @@
## develop #583 +/- ##
==========================================
Coverage ? 89.94%
==========================================
Files ? 32
Lines ? 2995
Branches ? 0
==========================================
Hits ? 2694
Misses ? 301
Partials ? 0
Continue to review full report at Codecov.
|
|
@mfeurer I added a new section in the tutorial |
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Thanks a lot for adding the section to the documentation. I think this can be merged if
- you resolve the conflict
- you fix the flake8 error
…et (openml#586) * EHN: inferred row_id_attribute from dataframe to create a dataset * reset the index of dataframe after inference * TST: check the size of the dataset * PEP8 * TST: check that an error is raised when row_id_attributes is not a known attribute * DOC: Update the docstring * PEP8
|
Done! |
7 participants
Add support for
SparseDataFramewhen creating a matrix.