Skip to content

Fix #580 #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janvanrijn merged 3 commits into from
Oct 22, 2018
Merged

Fix #580 #581

janvanrijn merged 3 commits into from
Oct 22, 2018

Conversation

@janvanrijn
Copy link
Member

@janvanrijn janvanrijn commented Oct 20, 2018

Fixes #580

@janvanrijn janvanrijn changed the base branch from master to develop October 20, 2018 16:22
@codecov-io
Copy link

codecov-io commented Oct 20, 2018

Codecov Report

Merging #581 into develop will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #581      +/-   ##
===========================================
+ Coverage    89.81%   89.82%   +0.01%     
===========================================
  Files           32       32              
  Lines         2956     2959       +3     
===========================================
+ Hits          2655     2658       +3     
  Misses         301      301
Impacted Files Coverage Δ
openml/evaluations/functions.py 94.59% <0%> (ø) ⬆️
openml/utils.py 92.85% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2f71f...a283df8. Read the comment docs.

@janvanrijn
Copy link
Member Author

janvanrijn commented Oct 22, 2018

Really appreciated, thanks!

@janvanrijn janvanrijn merged commit 95d12e5 into develop Oct 22, 2018
@janvanrijn janvanrijn deleted the fix_#580 branch October 22, 2018 12:41
@mfeurer mfeurer mentioned this pull request Dec 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfeurer mfeurer mfeurer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janvanrijn @codecov-io @mfeurer