Skip to content

Conversation

@joaquinvanschoren
Copy link
Contributor

What does this PR implement/fix? Explain your changes.

Adds documentation about running specific unit tests. I found this very useful and didn't know this beforehand.

@mfeurer
Copy link
Collaborator

mfeurer commented Oct 6, 2018

Hey, this is really useful, thanks a lot. Could you please extend this a bit by giving advice how to run all unit tests for a module, and also use a unit test which is already inside develop and which will most likely also stay there (for example something testing datasets/functions.py)?

@mfeurer
Copy link
Collaborator

mfeurer commented Nov 9, 2018

Hey, I think that my previous comment still applies and it would be great to have this additional information before merging this pull request.

@codecov-io
Copy link

Codecov Report

Merging #561 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #561      +/-   ##
===========================================
- Coverage     89.9%   89.87%   -0.04%     
===========================================
  Files           32       32              
  Lines         3031     3031              
===========================================
- Hits          2725     2724       -1     
- Misses         306      307       +1
Impacted Files Coverage Δ
openml/runs/functions.py 87.3% <0%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e69fe0...5160782. Read the comment docs.

Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks a lot!

@mfeurer mfeurer merged commit ecdf9b1 into develop Feb 13, 2019
@mfeurer mfeurer deleted the doc-hotfix branch February 13, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants