Skip to content

#563 Fixing run print bug with blank flow_name #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfeurer merged 1 commit into from
Sep 24, 2018
Merged

#563 Fixing run print bug with blank flow_name #552

mfeurer merged 1 commit into from
Sep 24, 2018

Conversation

@ledell
Copy link
Contributor

@ledell ledell commented Sep 22, 2018

Reference Issue

Fixes #536

What does this PR implement/fix? Explain your changes.

This fixes a bug where you can't print a run that has flow_name = None.

How should this PR be tested?

from sklearn import ensemble
from openml import tasks, flows, runs
import openml

task = tasks.get_task(3954)
clf = ensemble.RandomForestClassifier()
flow = flows.sklearn_to_flow(clf)
run = runs.run_flow_on_task(task, flow)
print(run)  #should print w/o error

@ledell ledell changed the base branch from master to develop September 22, 2018 13:38
mfeurer
mfeurer approved these changes Sep 24, 2018
View reviewed changes
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mfeurer mfeurer merged commit d3215c0 into openml:develop Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfeurer mfeurer mfeurer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Printing the result of a run gives an error when flow_name is None

2 participants

@ledell @mfeurer