[WIP] refactor flow interface #543
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey, thanks for putting this up! I just had a brief look and think it would be great if you could add some comments about the workflow. Currently, |
Collaborator
|
Superseded by #647. |
Author
|
@mfeurer heheh cool. would have been cool to know it earlier :) we'll have to amend our local patch to the extension as there are some already working things on top of it... will try to send in that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mfeurer check the interface design. i thought i will have time for the run_task part but that'll take a bit longer but i thought it's still better that you look at the interface.
the tests in
tests/test_flows/test_sklearn.pyall pass.