[MRG] TST: add test for creating datset from NumPy array #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
changed the title
mfeurer
approved these changes
Sep 20, 2018
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Looks great! Thanks a lot.
Codecov Report
@@ Coverage Diff @@
## develop #539 +/- ##
===========================================
+ Coverage 89.82% 90.07% +0.24%
===========================================
Files 32 32
Lines 2811 2811
===========================================
+ Hits 2525 2532 +7
+ Misses 286 279 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
closes #537
What does this PR implement/fix? Explain your changes.
Implement a unit test for the function
create_datasetfrom NumPy array.