Fix listing #464
Merged
Fix listing #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
requested changes
May 3, 2018
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Looks good. You could remove the cycle variable as it is always set to True and have a while True loop. Also, please note in the changelog that you fixed this bug. Finally, maybe it would be good to add a unit test which ensures that the number of downloaded results equals the number of actual results if the batch size is lower (for example by using the mock library in order to not spam the server).
Member
Author
|
Agreed to all. Except that I don't know mock that well, and won't be able to invest too much time right now. I added this test to the server. |
mfeurer
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed list_all function: