-
-
Notifications
You must be signed in to change notification settings - Fork 211
Updated installation instructions #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, do you maybe want to update the example, too? Also, could you please redirect your PR to the development branch? |
|
On it. do something like From what I've seen, people always use those two lines together without doing anything with the flow object. |
|
We have |
|
I updated the example, but there was nothing really wrong with it? |
mfeurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, actually I meant the IPython notebook. It contains installation instructions, too.
doc/index.rst
Outdated
| run.publish() | ||
| print('URL for run: %s/run/%d' % (openml.config.server, run.run_id)) | ||
| print('View the run online: https://www.openml.org/r/%d' % run.run_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is redundant given the line above.
|
@joaquinvanschoren I did some more changes - could you please also have a look again and approve it if you like it? |
|
Hmm, Travis fails because it can't find numpy in the Python 3.4 test. What should I do about this? |
Codecov Report
@@ Coverage Diff @@
## develop #456 +/- ##
========================================
Coverage 89.46% 89.46%
========================================
Files 32 32
Lines 2771 2771
========================================
Hits 2479 2479
Misses 292 292Continue to review full report at Codecov.
|
|
Oh oh, it seemed like Travis finished successfully, but then suddenly there was still a fail after I merged it. |
Reference Issue
What does this PR implement/fix? Explain your changes.
How should this PR be tested?
Any other comments?