-
-
Notifications
You must be signed in to change notification settings - Fork 211
Prepare new release #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Prepare new release #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clustering unit test
add task ids to docs of list_tasks
# Conflicts: # openml/datasets/functions.py
fix docstrings in list_datasets, some pep8
Cast data qualities to float
WIP dataset Tagging
Make task the default concept to work with
Datalist status
fixes #373 + unit test
* Created first basic template, removed redudant variable * Improving list_datasets * First implementation of the list_* with the limit tag active * First implementation of the feature, fixed bugs and refactored the code * Changing batch_size to be a keyword argument * Fixed not considering initial offset, removing size and the double offset key from the filter dict * Changing task_type_id argument name in accordance with the new implementation * Reverting previous solution for task_type_id, implementing another fix * Fix for python2 and changing the unit test which times out * Added another test method and did a slight change in an existing test method * Changing the assert value for the failing test method * Added the implementation to filter by uploader for flows, filter by task_type for runs, filter by multipple operator for tasks and also refactored the code according to PEP8 * Refactored code as requested
* ADD unit test to ensure example listing * Update test_study_examples.py
* MAINT bump required liac-arff version * Update requirements.txt
* ADD contributing guidelines and github templates * Update CONTRIBUTING.md * ADD reference to scikit-learn to the license * Added clarification for unit test on Windows.
* ADD hash checks to datasets * split target on comma, allows errors on multiple targets * FIX unit test
* Basic solution for private datasets * Faulty and not necessary implementation of finally * Fixed assertRaises call in test_get_data * Updated get_dataset * Fixed typo
* Have different directories for different servers * simplify based on jans comments * fix attribute access * Change variable name * Take into account Jans suggestions * Harmonize import, fix rebase errors * re-add accidentaly removed files * First try at a solution * Removing faulty fix * Fix for bug in unit test, method _get_cached_task * Removing FileNotFoundError as it does not exist in python2 * Fixing test_tagging * Changing id according to new solution * Change _remove_dataset_cache_dir to the new implementation
* Adding support for home directory symbol * Fixing backward compatibility
* ADD introductory snippet to front page of the docs * FIX issues with rst formatting
* FIX fixes and improves unit tests * ADD additional asserts to hunt down bug * ADD debug output * remove print statement
* FIX circle ci yaml file (remove requirements.txt) * circle ci: build docs on all branches
janvanrijn
approved these changes
Apr 23, 2018
Member
janvanrijn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of code for half a year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we're good to go for our first release on pypi as most bugs are resolved for now. I'd like to do this as a soft launch and not advertise it until with the next minor release the pypi site and documentation look perfect. I'll create a new milestone afterwards.