Skip to content

Improve error logging #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfeurer merged 3 commits into from
Apr 4, 2018
Merged

Improve error logging #428

mfeurer merged 3 commits into from
Apr 4, 2018

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Mar 29, 2018

No description provided.

@mfeurer mfeurer requested a review from janvanrijn March 29, 2018 13:40
@janvanrijn
Copy link
Member

janvanrijn commented Mar 29, 2018

Right now it gives this error:

======================================================================
ERROR: test__getarff_md5_issue (tests.test_datasets.test_dataset_functions.TestOpenMLDataset)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/openml/openml-python/tests/test_datasets/test_dataset_functions.py", line 275, in test__getarff_md5_issue
    self.workdir, description,
  File "/home/travis/miniconda/envs/testenv/lib/python2.7/unittest/case.py", line 993, in assertRaisesRegexp
    callable_obj(*args, **kwargs)
  File "/home/travis/build/openml/openml-python/openml/datasets/functions.py", line 414, in _get_dataset_arff
    md5_checksum, int(did), md5_checksum_fixture
OpenMLHashException: Checksum ad484452702105cbf3d30f8deaba39a9 of downloaded dataset 5 is unequal to the checksum abc sent by the server.
-------------------- >> begin captured logging << --------------------
fasteners.process_lock: Level 5: Acquired file lock `/home/travis/build/openml/openml-python/openml/tests.test_datasets.test_dataset_functions.TestOpenMLDataset.test__getarff_md5_issue/config` after waiting 0.000s [1 attempts were required]
fasteners.process_lock: Level 5: Unlocked and closed file lock open on `/home/travis/build/openml/openml-python/openml/tests.test_datasets.test_dataset_functions.TestOpenMLDataset.test__getarff_md5_issue/config`
urllib3.connectionpool: DEBUG: Starting new HTTPS connection (1): www.openml.org
urllib3.connectionpool: DEBUG: https://www.openml.org:443 "GET /data/download/61?api_key=610344db6388d9ba34f6db45a3cf71de HTTP/1.1" 200 None

@codecov-io
Copy link

codecov-io commented Mar 29, 2018 •
edited
Loading

Codecov Report

Merging #428 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #428     +/-   ##
==========================================
+ Coverage    89.37%   89.48%   +0.1%     
==========================================
  Files           32       32             
  Lines         2683     2749     +66     
==========================================
+ Hits          2398     2460     +62     
- Misses         285      289      +4
Impacted Files Coverage Δ
openml/datasets/dataset.py 80.87% <100%> (+3.23%) ⬆️
openml/exceptions.py 100% <100%> (ø) ⬆️
openml/datasets/functions.py 90.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06c4b9...fc5e383. Read the comment docs.

@mfeurer mfeurer merged commit 3232d0d into develop Apr 4, 2018
@mfeurer mfeurer deleted the improve_error_logging branch April 4, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janvanrijn janvanrijn janvanrijn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfeurer @janvanrijn @codecov-io