Skip to content

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Mar 29, 2018

New version is more resilient with respect to commas in data. However, it cannot yet read all commas, that's for the future.

@mfeurer mfeurer requested a review from janvanrijn March 29, 2018 08:32
@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #427 into develop will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #427      +/-   ##
==========================================
+ Coverage    89.37%   89.5%   +0.12%     
==========================================
  Files           32      32              
  Lines         2683    2744      +61     
==========================================
+ Hits          2398    2456      +58     
- Misses         285     288       +3
Impacted Files Coverage Δ
openml/datasets/dataset.py 81.01% <0%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b701bb...e789e5a. Read the comment docs.

Copy link
Member

@janvanrijn janvanrijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you're also maintaining the liac-arff library

@mfeurer
Copy link
Collaborator Author

mfeurer commented Mar 29, 2018

Yep...

@mfeurer mfeurer merged commit fb20762 into develop Mar 29, 2018
@mfeurer mfeurer deleted the maint/bump_liac_arff_dependency branch April 23, 2018 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants