ADD unit test to ensure example listing #421
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #421 +/- ##
========================================
Coverage 89.37% 89.37%
========================================
Files 32 32
Lines 2683 2683
========================================
Hits 2398 2398
Misses 285 285Continue to review full report at Codecov.
|
janvanrijn
left a comment
janvanrijn
left a comment
There was a problem hiding this comment.
Cool Unit test, very useful
| def test_Figure1a(self): | ||
| """Test listing in Figure 1a on a single task and the old OpenML100 study | ||
|
|
||
| import openml |
There was a problem hiding this comment.
you sure want to copy the code into the comment?
There was a problem hiding this comment.
That's the original code from the listing which is a bit different from the actual code of the unit test. So yes, I want this code there. I'll add a sentence about this.
| run.publish() # publish the experiment on OpenML (optional) | ||
| print('URL for run: %s/run/%d' %(openml.config.server,run.run_id)) | ||
| """ | ||
| import openml |
There was a problem hiding this comment.
Wouldn't it be possible to somehow load this from the appropriate (paper) repo? Or don't you want these dependencies? Or should we add this test actually there?
There was a problem hiding this comment.
I would like to avoid such dependencies such that users can run unit tests locally without having to install such dependencies which will most likely never make it to pypi.
No description provided.